Commit Graph

1133 Commits

Author SHA1 Message Date
Max Roncace ee32f5db55
d_a_vrbox2 matching (#2981) 2025-12-21 10:52:34 -08:00
LagoLunatic 16a2980f5a
Update to objdiff 3.5.0 (#2980)
* Update to objdiff 3.5.0

* Fix symbols being in .data instead of .rodata for Wii/Shield
2025-12-21 10:46:14 -08:00
LagoLunatic 48f1d47690
Work on weak order (#2979)
* JAUSectionHeap OK

* Slightly improve d_camera weak func order (12 -> 10)

* Minor d_a_alink fixes

* weak_order_diff.py: Change to take source file as cli argument instead of .o file

For cli autocompletion to work.

* Reorganize J3D structs (no change in weak order)
2025-12-21 14:13:21 +02:00
LagoLunatic f6e2cbca9d
Match d_a_obj_ice_s rideCallBack (#2977)
* Match d_a_obj_ice_s rideCallBack

Co-authored-by: Cuyler36 <Cuyler36@users.noreply.github.com>

* Fix debug regression

---------

Co-authored-by: Cuyler36 <Cuyler36@users.noreply.github.com>
2025-12-20 18:53:41 -08:00
TakaRikka bd0c601a52
m_Do_MemCard/d_file_select wii/debug work (#2976)
* m_Do_MemCard/d_file_select wii/debug work

* fix builds
2025-12-20 18:30:04 -08:00
Luzagar 762159a990
d_a_npc_ks documentation (#2970)
* npc_ks work

* more work

* fix debug

* more documentation
2025-12-20 18:10:44 -08:00
Carco_21 c434c2edde
Various d_ work (#2968)
* map work

* various meter work

* d_meter_button ShieldD almost equivalent

* error fix
2025-12-20 18:06:17 -08:00
LagoLunatic 0395053737
Match dNpcLib_lookat_c::action and daBaseNpc_lookat_c::calc (#2973)
* Match dNpcLib_lookat_c::action and daBaseNpc_lookat_c::calc

Co-authored-by: Cuyler36 <Cuyler36@users.noreply.github.com>

* Improve d_a_npc weak func order

---------

Co-authored-by: Cuyler36 <Cuyler36@users.noreply.github.com>
2025-12-19 22:59:16 -08:00
Jcw87 2c62444df1
m_Do_main debug (#2965) 2025-12-19 21:22:03 +02:00
LagoLunatic 21ce84ae43
d_a_npc_kn OK (#2966)
* d_a_npc_kn OK

* Remove nonmatching comment
2025-12-18 13:37:50 -08:00
roeming 93067110f6
Use consistent s32/u32 (#2964)
* cleanup long usage

* fix regression
2025-12-18 13:31:44 -08:00
Luzagar 7cae156176
fix ENABLE_REGHIO macro (#2963) 2025-12-18 13:31:00 -08:00
Niklas Bauer c0bdb153b5
random debug objects (#2961) 2025-12-17 11:26:51 +02:00
LagoLunatic 6a02f5b387
d_a_npc_wrestler 100% (#2962)
* Match sumouPunchMiss, improve sumouPunchChaseShock

Removing these consts also matches several functions on debug.

* Match sumouSideStep and sumouPunchChaseShock
2025-12-16 22:45:46 +02:00
Jcw87 c8104b6d62
d_meter_HIO debug (#2959) 2025-12-16 16:54:05 +02:00
LagoLunatic 497aa20aa9
d_a_movie_player OK (#2958)
* Match THPAudioDecode

* Match daMP_MixAudio

* Fix weak func order

* Fix global.h
2025-12-16 16:52:28 +02:00
LagoLunatic d4859f8595
d_a_alink 100% (#2957)
* Match daAlink_c::checkHorseGetOff

* Match daAlink_c::procCanoeRowInit
2025-12-15 17:09:39 -08:00
Max Roncace b9cb15ad98
Enable regHIO for Wii USA R0 (#2953) 2025-12-15 17:06:10 -08:00
Luzagar 618a3783f8
d_a_e_b +d_a_e_bi_leaf documentation (#2952)
* some e_bi documentation

* fix match issue

* fix error

* e_bi_leaf documentation
2025-12-15 17:04:20 -08:00
Carco_21 86bf768665
d_a_obj_bemos debug work (#2947)
* debug work

* PR cleanup
2025-12-15 17:02:29 -08:00
LagoLunatic 1b8ea3206d
J3D debug work (#2949)
* J3D debug work

* Clean up JSystem GXColor ctors, remove a couple fakematches

* Update symbols.txt

* Fix res include syntax

* Remove fakematch that isn't necessary anymore

* Fix some Shield regressions
2025-12-12 21:04:03 -08:00
roeming 7e514502d2
d_a_obj_movebox debug work (#2948)
* match lots of debug for d_a_obj_movebox

* the rest of the debug work
2025-12-12 21:01:48 -08:00
Carco_21 87732304d1
d_particle debug work (#2944)
* misc work

* more work

* fixed error

* more work

* PR cleanup

* missed cleanup

* error fix

* wii fix
2025-12-12 20:54:42 -08:00
Max Roncace 8ad2d661a2
Clean up conditional compilation a bit (#2943) 2025-12-11 15:34:16 -08:00
Jcw87 ae4ad9f477
fix functions not returning values (#2942)
* fix functions not returning values

* implement functions that should return values
2025-12-11 15:31:44 -08:00
hatal175 2c6986f1cc
Work on d_a_obj_ice_s debug (#2941) 2025-12-10 15:06:57 -08:00
LagoLunatic 2447d5a02a
d_a_npc_cdn3 OK (#2935) 2025-12-09 22:41:11 +02:00
Carco_21 60645e1423
d_a_e_gb debug + documentation (#2916)
* cleanup and documentation

* PR cleanup
2025-12-08 20:33:55 -08:00
Carco_21 bff5982293
almost matching (#2933) 2025-12-08 22:12:20 +02:00
Carco_21 c74ce87f5a
decent work (#2931) 2025-12-08 22:10:37 +02:00
roeming 07a4e6b052
match debug for D_menu_fmap2_d (#2925)
* menu_fmap2d debug progress

* match debug for d_menu_fmap2D

* fix broken function

* fix weird shield mismatch

* fix other shield mismatch

* fix suggestions

* fix func for wii version

* match func for all versions

* remove cast from saveBitLabels
2025-12-07 17:09:47 -08:00
LagoLunatic 40a8b9ed54
d_a_npc_blue_ns OK (#2924)
* Match daNpcBlueNS_c::_Execute

* Cleanup loop

* d_a_npc_blue_ns OK
2025-12-07 12:26:55 -07:00
Max Roncace 136f6b3f40
d_kankyo debug work (#2918)
* Global: Define DEBUG as 0 if not already defined

* Clean up DEBUG-guarded code

* d_kankyo debug almost matching
2025-12-06 13:39:30 -08:00
Max Roncace a30e617e5a
Various debug conditional compilation cleanup (#2915)
* Global: Define DEBUG as 0 if not already defined

* Clean up DEBUG-guarded code
2025-12-06 13:34:47 -08:00
kipcode66 9f1a648851
fix TPosition3.h (#2919) 2025-12-05 22:24:34 -08:00
LagoLunatic ae9fa8922a
Work on weak function ordering (#2917)
* Fix functionvalue weak func order

* Add script to help diffing weak function order

* Improve alink weak func order (44 -> 15)

* Improve m_Do_ext weak order (12 -> 7)

* Remove old hack

* Fix d_a_tbox weak func order

* Fix d_a_npc_ks weak func order

* Fix error when trying to diff weak func order for ShieldD due to hidden function alignment gap symbols
2025-12-05 18:46:58 -08:00
Carco_21 e6b1f3a4f2
d_a_e_mk debug work + documentation (#2913)
* initial work

* documentation
2025-12-05 18:37:17 -08:00
LagoLunatic 7fe9a68a9d
d_a_horse 100% (#2912)
* Fix missing line numbers for debug

* Fix horse inlines and HIO

* Match daHorse_c::setEffect

* Improve a few debug matches

* Match daHorse_c::checkHorseNoMove (half fake)

* Update configure.py
2025-12-04 16:03:13 -08:00
Niklas Bauer 4d3f25d34e
Resolve all "illegal jump past declaration/initializer" warnings (#2911)
* resolve illegal jump past declaration/initializer

* pr comments
2025-12-04 14:57:33 +02:00
LagoLunatic f97d334732
Debug+retail matches and clean up some fakematches (#2910)
* Debug matches

* Match daAlink_c::procGrassWhistleWait

* Match JASAramStream::channelProc

* More debug matches

* Match JAUStreamStaticAramMgr_::deleteStreamAram and bitset inlines

* Fix some fakematches

* Fix gameinfo player info not being a struct

* Update bug comments

* Fix procids in alink

* d_a_scene_exit OK
2025-12-03 15:09:56 -08:00
Carco_21 5716efc4c8
d_a_e_dn work (#2899)
* d_a_e_dn work

* PR cleanup and more documentation
2025-12-03 14:16:08 -08:00
Niklas Bauer c1861812ef
d_a_npc_kn debug work (#2907)
* d_a_npc_kn debug work

* d_a_npc_kn pr comments
2025-12-03 20:30:59 +02:00
LagoLunatic e39af8edf5
Match 4 more functions (#2909)
* Match daNpcF_Lookat_c::adjustMoveDisAngle

* Match daNpc_ykM_c::reset and daNpc_ykW_c::reset

* Fakematch daNpcThe_c::main gameInfo load

* Update configure.py
2025-12-02 18:18:28 -08:00
Niklas Bauer 9a69fa38c7
d_a_obj_brakeeff debug equivalent (#2906)
* d_a_obj_brakeeff fmt

* d_a_obj_brakeeff debug equivalent
2025-12-02 15:33:29 -08:00
Niklas Bauer d2d45c58ee
d_a_obj_damcps debug equivalent (#2904)
* d_a_obj_damcps initial

* d_a_obj_damcps guard

* d_a_obj_damcps pr comments
2025-12-02 22:44:39 +02:00
Niklas Bauer 2260191fe6
Consistent cull_box struct usage (#2905)
* consistent cullbox usage

* d_a_obj_waterPillar debug work so its not a regression
2025-12-02 20:34:19 +02:00
LagoLunatic ffc86e0412
Fix HIO load issues (#2903)
* Fix HIO load order in daHoZelda_c::searchBodyAngle

* Fix regression in daHoZelda_c::createHeap

Apparently the HIO class being constructed having an explicit ctor breaks the compiler ability to branchlessly optimize the false/true return afterwards. Without an explicit ctor the compiler is able to optimize it successfully, which breaks the match.

* Fix HIO load order in daNpc_ykW_c::setAttnPos

* Remove false version diff

* Update configure.py

* Remove old comment

* Fix alink HIO members being private

* alink: Fix HIO loads in 3 retail functions and almost all debug functions
2025-12-01 18:37:04 -08:00
Sven Elmendorp 737db261e9
Some variable names for hookshot and moved some values (#2900)
* Some variable names for hookshot and moved some values

* Revert using data.inc file
2025-12-01 16:36:09 -08:00
LagoLunatic 1e2d9151a0
d_a_tag_kmsg OK (#2901) 2025-12-01 13:33:12 -08:00
TakaRikka a6e76c0841
project cleanup (#2895)
* some wii OS fixes

* remove old dol2asm comments

* remove dol2asm.h

* remove function address comments

* normalize ATTRIBUTE_ALIGN usage

* DECL_WEAK macro

* fix gcc attribute weak macro

* wrap more mwcc specific things in ifdefs

* fixes

* fix revo sdk version flags

* fixes
2025-11-30 15:23:42 -07:00
Howard Luck 20e9957356
d_a_alink_HIO work (#2852)
* daAlink_c::jointControll OK

* daalink debug work

* checkpoint

* fix casting

* checkpoint

* checkpoint

* checkpoint

* checkpoint

* checkpoint

* checkpoint

* checkpoint

* remaining functions + fixes round 1

* fixes round 2

* fixes round 3

* fixes round 4

* revert getNeckAimAngle for now
2025-11-30 22:26:50 +02:00
Niklas Bauer 1be301393b
d_a_obj_crvgate debug almost matching (#2880)
* Match d_a_obj_crvgate debug

* d_a_obj_crvgate remove this->
2025-11-29 14:51:45 -08:00
Max Roncace 89ccf4c7ef
d_a_bg debug work + matching for retail (#2890) 2025-11-29 22:11:21 +02:00
Julian Maynes 72c37de758
D_a_e_mm_mt 99% matching (#2881)
* do draw, smbindeffect, isdelete, delete, most of heapinit

* Fix lowercase hex

* fix style

* Add spaces after if

* Do most of drop and carry

* Almost done

* Finish normal

* Get functions to mostly regalloc + a few compiler quirks.

* fix up comments

* Fix all issues and get everything to 100
2025-11-29 00:55:42 -08:00
LagoLunatic c974c979ee
d_a_passer_mng OK (#2885) 2025-11-28 11:29:09 -08:00
LagoLunatic ff550da0b2
d_map_path_dmap OK (#2884) 2025-11-28 11:28:27 -08:00
LagoLunatic 4fb3af91b8
Various small matches (#2879)
* Misc debug matches

* Fix JASBasicWaveBank weak func order

* Remove more dol2asm stuff, fix missing includes

* Some data fixes

* Update comments

* d_file_sel_warning is already OK

* Fix Z2 splits

* Fix movebox namespace

* Fix inlining issue in m_Do_ext

* Fix Z2 splits for P and J
2025-11-27 21:34:18 -08:00
Niklas Bauer a089a1d21c
d_a_player checks debug work (#2878)
* Match player checks via BOOL

* PR comment

* resolve conflict
2025-11-27 21:20:22 -08:00
TakaRikka 6f96e66518
various Z2Audio / JAudio debug cleanup (#2876)
* some JAudio work

* audio cleanup checkpoint

* checkpoint more audio cleanup

* fix symbols

* more z2 cleanup

* fix regression

* fix build

* some fixes
2025-11-27 21:19:33 -08:00
Max Roncace 767caeecc3
d_a_npc_ykm debug almost matching (#2877) 2025-11-27 14:28:39 -08:00
Carco_21 f8d6c5fe1b
rafrel debug almost matching (#2866) 2025-11-27 14:24:44 -08:00
Carco_21 4d4444ca18
d_a_b_mgn debug almost equivalent (#2842)
* debug almost equivalent

* PR cleanup
2025-11-27 14:22:27 -08:00
Max Roncace 90133fb1cb
Small d_a_mg_rod fixes (#2874) 2025-11-26 20:01:55 -08:00
Max Roncace 3080360a2a
d_kankyo matching (#2872) 2025-11-26 13:52:12 -08:00
Niklas Bauer c619b761e6
d_a_obj_carry ALL_GCN matching (#2871)
* d_a_obj_carry matching

* d_a_obj_carry::execute() debug matching
2025-11-26 19:27:50 +02:00
Max Roncace 2bff9b49b5
d_particle equivalent (#2869) 2025-11-25 20:55:01 -08:00
hev7 43e2dadc12
Link b_mgn, tbox equivalent (#2867)
* Link b_mgn

* tbox equivalent
2025-11-25 20:48:34 -08:00
Max Roncace 9f76ba2f69
d_a_npc debug work (#2863)
* Remove d_a_npc3.cpp

This file appears to not actually be real and the asserts in its
functions all reference d_a_npc2.cpp instead.

* d_a_npc debug almost matching
2025-11-25 22:32:01 +02:00
LagoLunatic 7ca9ef46db
d_a_mg_rod equivalent (#2865) 2025-11-25 22:29:44 +02:00
Max Roncace 9943a52a79
Move cBgS_GrpPassChk and cBgS_PolyPassChk to separate headers (#2861)
This is supported by RTTI ordering which only makes sense if these
classes are in separate headers from the dBgS_* classes.
2025-11-25 18:39:11 +02:00
Carco_21 f5e3e89512
d_a_mg_rod a little closer to matching (#2857)
* closer to matching

* build error fix

* PR cleanup
2025-11-25 18:36:25 +02:00
hev7 cd3d634133
Link npc_guard (#2859) 2025-11-24 15:30:01 -08:00
LagoLunatic 97c60c9092
Match 5 d_bg_w_kcol funcs (#2856)
* dBgWKCol::CaptPoly equivalent

* dBgWKCol::CaptPoly OK

* Switch s32->int for the rest of the dBgW functions just in case

This doesn't immediately help any other functions besides CaptPoly, but I suspect it could help prevent issues in the future since it's more likely to be what the original devs did.

* Debug var fix

* Match 3 more kcol funcs

* Remove unused lits

* Update nonmatching comments

* Fix ChkShdwDrawThrough
2025-11-23 22:07:35 -08:00
roeming 178191908c
kcol progress (#2855) 2025-11-23 21:16:42 -08:00
YunataSavior 818bd2f0bf
Some npc_ks dbg work (#2854) 2025-11-23 21:14:20 -08:00
YunataSavior 0cc9ebd724
Link npc_zra (#2853) 2025-11-23 21:10:24 -08:00
hev7 6067c05f14
Link npc_doc (#2851)
* Link npc_doc

* Remove changes causing regression in debug
2025-11-23 21:09:19 -08:00
LagoLunatic 8d53f6dd59
Fix more nonmatchings (#2850)
* Fix GetPolyIndex and GetBgIndex, fixing a couple regallocs

* Match daNpcCd2_c::checkFearSituation and daNpcCd2_c::getAnmP

* Match daAlink_c::jointControll

* Clean up float class checks

* Move float constants to global.h
2025-11-23 15:23:44 -08:00
Trueffel eaf980174f
d_a_npc_guard all functions OK (#2849)
* guard about to match

* weak func order messes linking up

* improve executePath
2025-11-23 21:51:19 +02:00
Max Roncace f2ad303961
Link d_msg_class (all) and d_msg_unit (JP only), minor alink fix (#2846) 2025-11-21 21:45:29 -08:00
LagoLunatic e2fddadf32
Misc matches (#2845)
* Misc debug matches

* Fix d_map weak function order

* Remove old nonmatching comments

* d_menu_dmap and JASAudioThread OK, fix weak func order and rodata alignment

* More misc matches
2025-11-21 15:52:16 -08:00
Max Roncace 31621c3dac
Link d_name for GCN JPN (#2843) 2025-11-21 14:27:21 -08:00
TakaRikka 726d7e22c2
npc_doc almost (#2840)
* npc_doc almost

* pr
2025-11-21 13:57:35 +02:00
maimai0254 b24b9a798c
npc_grm OK (#2841)
* npc_grm OK

* uncomment debug stuff

* fix {
2025-11-21 01:47:47 -08:00
YunataSavior 03f8a804fc
Link e_hp (#2838) 2025-11-20 23:26:45 -08:00
Max Roncace e6a5d5c3dd
Miscellaneous retail+debug fixes, link several new TUs (#2836) 2025-11-20 23:09:21 -08:00
LagoLunatic 91011befd7
Remove fake matches, fix false equivalencies, and other small matches (#2837)
* Debug matches and remove fake matches

* Fix false equivalencies, regallocs, and vtable orders

* Fix PAL splits
2025-11-20 21:17:51 -08:00
roeming 6f7457a870
add debug functionality to d_a_horse, match almost all functions (#2834)
* add debug functinality to d_a_horse, match almost all functions

* fix some wii funcs

* fix wii build
2025-11-20 14:41:52 -08:00
Carco_21 248f57b257
npc_midna linked (#2835) 2025-11-20 11:53:19 -08:00
Carco_21 e7270bf7ab
d_a_kytag13 matching + small various work (#2826)
* kytag13 matching

* pr cleanup
2025-11-20 11:47:11 -08:00
YunataSavior 8815bd5da9
Link npc_shoe (#2833) 2025-11-19 22:49:08 -08:00
LagoLunatic 4cf2c7e37d
Misc fixes (#2830)
* Replace DANPCF_C_HACK with a better fakematch

* d_a_obj_item OK

* Fix ninja diff

* Misc debug/nonmatching fixes

* Fix ninja diff for PAL

* Fix bad PAL split
2025-11-19 14:10:03 -08:00
Max Roncace 8956be538e
d_a_npc_grs matching (#2827) 2025-11-19 13:27:28 -08:00
hev7 4373bba251
d_a_npc_soldierB matching (#2828) 2025-11-19 12:53:12 -08:00
Carco_21 9d325bfb29
d_a_npc_pachi_taro and d_a_npc_pachi_maro matching (#2824)
* solid progress

* almost matching

* pachi_taro matching

* pachi_maro matching
2025-11-19 10:07:35 -08:00
Max Roncace 7f863c069b
d_a_npc_chin matching (#2822) 2025-11-18 21:10:04 -08:00
hev7 1b2fe5e2e3
d_a_npc_grd matching (#2821)
* d_a_npc_grd matching

* Fix regression

* Fix
2025-11-18 18:21:48 -08:00
hatal175 158899a16d
debug work on d_a_e_fb (#2819) 2025-11-18 01:34:52 -08:00
TakaRikka 638c0b968c
npc_gnd finished, movie_player almost done (#2818)
* movie_player mostly done

* d_a_npc_gnd done

* fix fshop debug match
2025-11-18 01:34:34 -08:00
LagoLunatic bd2def28db
d_a_demo00 OK (#2817)
* Misc small matches

* Add J3DFrameCtrl::EMode_NULL enum

* Improve weak bss fakematch and remove a functionvalue fakematch

* demo00 OK
2025-11-17 15:38:04 -08:00